Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ecephys and ophys tutorials #1915

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Update ecephys and ophys tutorials #1915

merged 1 commit into from
Jun 13, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Jun 13, 2024

Motivation

Remove docs for external storage of tiff data in ophys. Add descriptions to TimeSeries. Run nwbinspector on outputs.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from bendichter June 13, 2024 15:49
@codecov Codecov
Copy link

codecov bot commented Jun 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (194ce9c) to head (a139870).
Report is 20 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #1915   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files          27       27           
  Lines        2651     2651           
  Branches      692      692           
=======================================
  Hits         2436     2436           
  Misses        142      142           
  Partials       73       73
Flag Coverage Δ
integration 72.80% <ø> (ø)
unit 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bendichter bendichter enabled auto-merge (squash) June 13, 2024 16:03
@bendichter bendichter merged commit 90e6048 into dev Jun 13, 2024
24 checks passed
@bendichter bendichter deleted the update_tutorials branch June 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendichter bendichter bendichter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rly @bendichter